Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect settings in pom for 1.26 release #757

Closed
tledoux opened this issue Jun 17, 2022 · 1 comment · Fixed by #758 or #775
Closed

Incorrect settings in pom for 1.26 release #757

tledoux opened this issue Jun 17, 2022 · 1 comment · Fixed by #758 or #775
Assignees
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release

Comments

@tledoux
Copy link
Contributor

tledoux commented Jun 17, 2022

The 1.26 release contains 2 incorrect settings with unexpected results.

In the pom.xml of the jpeg-hul module, the dependency with the tiff-hul module is set to 1.9.1 instead of 1.9.3
which results in importing the 1.24 version in the maven repository.

Additionnaly, the parent pom.xml defines the compilation target of java 8 by the way of

<java.source.version>1.8</java.source.version>
<java.target.version>1.8</java.target.version>

this leads to the bad call of the ByteBuffer.position(I) from ByteBuffer instead of Buffer when executing with a java 8 VM.
This is best explained in https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/

The above properties should be changed by : <maven.compiler.release>8</maven.compiler.release>
in order to invoke the --release option during the compilation phase.

tledoux pushed a commit to tledoux/jhove that referenced this issue Jun 17, 2022
@carlwilson
Copy link
Member

Thanks for this @tledoux, it looks like a patch is required, will look at this very soon.

@carlwilson carlwilson self-assigned this Jun 21, 2022
@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Jun 21, 2022
This was referenced Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants