-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an array level in JSON output to repInfo #728
Add an array level in JSON output to repInfo #728
Conversation
…st of files to validated Fixes openpreserve#667
Codecov Report
@@ Coverage Diff @@
## integration #728 +/- ##
=================================================
+ Coverage 45.68% 46.46% +0.77%
- Complexity 1049 1054 +5
=================================================
Files 57 57
Lines 9147 9059 -88
Branches 1684 1606 -78
=================================================
+ Hits 4179 4209 +30
+ Misses 4410 4308 -102
+ Partials 558 542 -16
Continue to review full report at Codecov.
|
Thanks, @tledoux I was going to look at this myself as one of a couple of PRs of my own, but I hadn't done it yet so you've saved me some time. Will take a look shortly. |
Hi @carlwilson , most welcome to help you on this. |
Thanks once again @tledoux. There are plenty of overcomplex methods in the code base that have been there for a long time. In many cases it's not a new problem, you get blamed simply for touching a function that was already overlong. TLDR, don't worry too much about the QA :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to test results 👍
in order to support a list of files to be validated
Fixes #667