Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name and LastMod in Annotation can be encrypted #781

Conversation

samalloing
Copy link
Collaborator

Hi @carlwilson

Again a small pull request when a file is encrypted the information in Name and LastModified of Annotations can also be encrypted. This shows that the information can be encrypted in these field. This is also what happens in the Contents field

Sam

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Base: 46.22% // Head: 29.18% // Decreases project coverage by -17.05% ⚠️

Coverage data is based on head (9c1aa37) compared to base (a7e8dff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             integration     #781       +/-   ##
==================================================
- Coverage          46.22%   29.18%   -17.05%     
+ Complexity          1056      597      -459     
==================================================
  Files                 57       57               
  Lines               9057     9057               
  Branches            1607     1607               
==================================================
- Hits                4187     2643     -1544     
- Misses              4330     6033     +1703     
+ Partials             540      381      -159     
Impacted Files Coverage Δ
...n/java/edu/harvard/hul/ois/jhove/DocumentType.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/edu/harvard/hul/ois/jhove/SignatureType.java 0.00% <0.00%> (-100.00%) ⬇️
...java/edu/harvard/hul/ois/jhove/IdentifierType.java 0.00% <0.00%> (-100.00%) ⬇️
...va/edu/harvard/hul/ois/jhove/SignatureUseType.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/edu/harvard/hul/ois/jhove/Signature.java 0.00% <0.00%> (-97.06%) ⬇️
...main/java/edu/harvard/hul/ois/jhove/XMPSource.java 0.00% <0.00%> (-91.18%) ⬇️
.../main/java/edu/harvard/hul/ois/jhove/Document.java 0.00% <0.00%> (-87.88%) ⬇️
...c/main/java/edu/harvard/hul/ois/jhove/Message.java 0.00% <0.00%> (-72.00%) ⬇️
...ain/java/edu/harvard/hul/ois/jhove/Identifier.java 0.00% <0.00%> (-70.00%) ⬇️
...edu/harvard/hul/ois/jhove/ChecksumInputStream.java 0.00% <0.00%> (-68.43%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samalloing
Copy link
Collaborator Author

Hi @carlwilson

I updated this pull request, because also CreationDate and ModDate are encrypted is this file. The information is now shown but as encrypted instead of omitted.

Hopefully this didn't mess up my pull request. I 'm also trying to improve my git skills ;-)

Sam

@carlwilson carlwilson self-assigned this Nov 30, 2022
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Nov 30, 2022
@carlwilson
Copy link
Member

This one seems to have been committed already as part of the other merges so I can close it safely, thank @samalloing

@carlwilson carlwilson closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants