Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Messages with no ID #832

Merged
merged 2 commits into from
Mar 15, 2023
Merged

FIX: Messages with no ID #832

merged 2 commits into from
Mar 15, 2023

Conversation

carlwilson
Copy link
Member

  • added IDs to remaining message constants without them; and
  • remove unnecssary code paths for messages with no ID.

- added IDs to remaining message constants without them; and
- remove unnecssary code paths for messages with no ID.
@carlwilson carlwilson added the bug A product defect that needs fixing label Feb 7, 2023
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Feb 7, 2023
@carlwilson carlwilson self-assigned this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ccbc2b0) 46.22% compared to head (3586754) 46.22%.

❗ Current head 3586754 differs from pull request most recent head ef1d25e. Consider uploading reports for the commit ef1d25e to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             integration     #832   +/-   ##
==============================================
  Coverage          46.22%   46.22%           
  Complexity          1056     1056           
==============================================
  Files                 57       57           
  Lines               9057     9057           
  Branches            1607     1607           
==============================================
  Hits                4187     4187           
  Misses              4330     4330           
  Partials             540      540           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlwilson carlwilson merged commit f1b5af8 into integration Mar 15, 2023
@carlwilson carlwilson deleted the mess/jpeg2000-hul branch March 15, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant