Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new myst build in pullrequest and push #57

Merged
merged 19 commits into from
Aug 12, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Aug 9, 2024

A bit more context, what I'm trying to achieve:

PR

  • Use build-book-pullrequest.yaml to rebuild the docker container and myst build the book.
  • zip the book
  • deploy it as preview to GH Pages

Push to Main

  • Use build-book.yaml to rebuild the docker container and push it to the registry, myst build the book.
  • zip the book
  • deploy it to GH Pages

Copy link

github-actions bot commented Aug 9, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: b5276f4
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/57

@kmuehlbauer
Copy link
Collaborator Author

So it looks like the thing is built inside the container, but for some reason the mapping to the outside (GitHub workspace) doesn't work.

Need to stop now. Moving forward over the weekend hopefully.

@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 If at first you don't succeed... It was there right from the beginning.

I'm not sure why the output https://openradar.github.io/erad2024/_preview/57 looks like it is missing some layout stuff. Maybe because the BASE_URL isn't set and the upload isn't done via the gh pages uploader?

Anyway, that's a good move forward. I'll clean this up and reinstate the removed things over the weekend.

Next steps would be to enable the build-book to do the same. Then we should be safe.

@kmuehlbauer kmuehlbauer changed the title try to myst build the book in pullrequest DO NOT MERGE: try to myst build the book in pullrequest Aug 9, 2024
@mgrover1
Copy link
Contributor

mgrover1 commented Aug 9, 2024

Sounds good! Thanks for all the hard work here @kmuehlbauer 😄

@kmuehlbauer
Copy link
Collaborator Author

✔️ Success! Now everything runs smoothly for the PR build. And the website is looking good, too.

I'm going to clean-up now and try to fix the build-book.yaml CU run accordingly.

@kmuehlbauer kmuehlbauer changed the title DO NOT MERGE: try to myst build the book in pullrequest Use new myst build in pullrequest and push Aug 12, 2024
@kmuehlbauer
Copy link
Collaborator Author

This is working now as intended. As we can't test the build-book CI run (push) here, let's just test it ;-)

@kmuehlbauer kmuehlbauer merged commit c205b70 into openradar:main Aug 12, 2024
2 checks passed
@kmuehlbauer kmuehlbauer deleted the myst-build-pullrequest branch August 12, 2024 09:56
github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants