-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new myst build in pullrequest and push #57
Use new myst build in pullrequest and push #57
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
So it looks like the thing is built inside the container, but for some reason the mapping to the outside (GitHub workspace) doesn't work. Need to stop now. Moving forward over the weekend hopefully. |
@mgrover1 If at first you don't succeed... It was there right from the beginning. I'm not sure why the output https://openradar.github.io/erad2024/_preview/57 looks like it is missing some layout stuff. Maybe because the BASE_URL isn't set and the upload isn't done via the gh pages uploader? Anyway, that's a good move forward. I'll clean this up and reinstate the removed things over the weekend. Next steps would be to enable the |
Sounds good! Thanks for all the hard work here @kmuehlbauer 😄 |
✔️ Success! Now everything runs smoothly for the PR build. And the website is looking good, too. I'm going to clean-up now and try to fix the |
0d6634d
to
acadca0
Compare
This is working now as intended. As we can't test the build-book CI run (push) here, let's just test it ;-) |
A bit more context, what I'm trying to achieve:
PR
build-book-pullrequest.yaml
to rebuild the docker container and myst build the book.Push to Main
build-book.yaml
to rebuild the docker container and push it to the registry, myst build the book.