Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell precommit #88

Closed
wants to merge 2 commits into from
Closed

Conversation

ghiggi
Copy link
Contributor

@ghiggi ghiggi commented Aug 23, 2024

Add codespell precommit to indentify typos in code and documentation. Close ##85

Copy link

github-actions bot commented Aug 23, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: edfa0ed
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/88

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment inline. What has actually been changed in the .svg? Does that change make sense?

@@ -9,5 +9,5 @@ index 3caf9cd..49b79ea 100644
-#define MOD_INIT_SETUP_TYPE(itype, otype) Py_TYPE(&itype) = otype
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghiggi Can we exclude the install-folder? We do not want to change anything there as we just fetch it from upstream.

@ghiggi
Copy link
Contributor Author

ghiggi commented Aug 23, 2024

Please merge #89 instead ;)

@ghiggi ghiggi closed this Aug 23, 2024
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants