Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: do not apply scale/offset in datamet reader, leave it to xarray instead #209

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Sep 17, 2024

  • Closes #xxxx
  • Tests added
  • Changes are documented in history.md

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.97%. Comparing base (34a9e82) to head (53445da).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
xradar/io/backends/datamet.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files          23       23              
  Lines        4541     4538       -3     
==========================================
- Hits         4177     4174       -3     
  Misses        364      364              
Flag Coverage Δ
notebooktests 78.25% <0.00%> (+0.05%) ⬆️
unittests 90.23% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer kmuehlbauer merged commit 71ebcc6 into openradar:main Sep 19, 2024
9 of 11 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-datamet branch September 19, 2024 05:49
rcjackson pushed a commit to rcjackson/xradar that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant