Datetime picker #33
Merged
Datetime picker #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzurkowski
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
The code looks good to me 👍 I think the change is ready to merge 🟢 Good work!
One side remark. We actually want to deliver the graph reload functionality in our MVP. I mean, after the user selects date and time, the graph should present its state from the past. It's a stunning feature that we want to present in the demo.
As you said, let's merge the datetime picker and focus on the reload in a separate PR. Please treat this with high priority 😉
The graph reload feature will be also needed for graph filtering and any other functionality that transforms the graph structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce datetime picker in OpenRCA and closes #26.
So far there is possibility to choose any past date. Then request to Mock API is generated. During this task I also planned to add graph reloading based on Mock API response, but it turned out no to be so easy. I plan to deliver this functionality in separate PR.