Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-deterministic link source-target ordering #56

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Fix non-deterministic link source-target ordering #56

merged 2 commits into from
Apr 17, 2020

Conversation

bzurkowski
Copy link
Member

Fixes non-deterministic link IDs due to lack of link source-target node ordering:

current links: {'d2f6d901-1eb6-50fe-890e-2a337a6bd0c5': <Link id=d2f6d901-1eb6-50fe-890e-2a337a6bd0c5 properties={} source=85b695c0-9ed6-4ea9-bf12-ad06488d86c1 target=9d45f2c4-89ad-4993-b162-a7a0c398d76b>} 

new links: {'15f297c8-1873-5ab1-b5b9-e430279aeaf8': <Link id=15f297c8-1873-5ab1-b5b9-e430279aeaf8 properties={} source=85b695c0-9ed6-4ea9-bf12-ad06488d86c1 target=9d45f2c4-89ad-4993-b162-a7a0c398d76b>}

@bzurkowski
Ensure fixed link source-target ordering
dcf540f 
Signed-off-by: Bartosz Zurkowski <zurkowski.bartosz@gmail.com>
@bzurkowski
Respect node origin in linker
0254a8d 
Signed-off-by: Bartosz Zurkowski <zurkowski.bartosz@gmail.com>
@bzurkowski bzurkowski added the bug Something isn't working label Apr 17, 2020
@bzurkowski bzurkowski added this to the 0.1 milestone Apr 17, 2020
@bzurkowski bzurkowski self-assigned this Apr 17, 2020
@bzurkowski bzurkowski merged commit 5934416 into master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bzurkowski bzurkowski

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
1 participant
@bzurkowski