Add probe for Kubernetes ingress #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It implements openrca#28 Signed-off-by: Aleksandra Galara <a.galara@samsung.com>
bzurkowski
requested changes
May 4, 2020
| def _extract_rules(self, entity): | ||
| rules = [] | ||
| for rule in entity.spec.rules: | ||
| properties = {} |
There was a problem hiding this comment.
Let's add rule host property as well.
orca/topology/infra/k8s/extractor.py
Outdated
| rules.append(properties) | ||
| return rules | ||
|
|
||
| def _extract_values(self, rule): |
There was a problem hiding this comment.
I suggest renaming the method to _extract_paths.
| def _extract_values(self, rule): | ||
| values = [] | ||
| for path in rule.http.paths: | ||
| properties = {} |
There was a problem hiding this comment.
Let's add path property as well.
orca/topology/infra/k8s/matcher.py
Outdated
| @@ -218,6 +218,23 @@ def are_linked(self, obj, namespace): | |||
| return namespace.properties.name == obj.properties.namespace | |||
|
|
|||
|
|
|||
| class IngressToServiceMatcher(Matcher): | |||
|
|
|||
| """Generic matcher for links between Ingress and Service entities.""" | |||
There was a problem hiding this comment.
It's not a "generic" linker (e.g. for links between a namespace and ANY resource). It's a linker for links between concrete entity types: ingress and service. Remove the generic keyword from the docstring.
orca/topology/infra/k8s/matcher.py
Outdated
| matched_service = self._match_service(ingress, service) | ||
| return matched_namespace and matched_service | ||
|
|
||
| def _match_service(self, ingress, service): |
There was a problem hiding this comment.
Since we're matching rules here, I suggest renaming the method to _match_rules.
Signed-off-by: Aleksandra Galara <a.galara@samsung.com>
bzurkowski
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It implements #28
Signed-off-by: Aleksandra Galara a.galara@samsung.com