This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Avoid collecting unnecessary snapshots #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check the above conflict and fix it? It's a weird one. |
arnau
force-pushed
the
avoid_snapshots_in_rsf_load
branch
from
f59ec22
to
b6d4ebe
Compare
|
It was a conflict with the introduction of "progress". I will remove it once we have this PR and #19 merged to master. The progress function was useful to see the progress during rsf slicing. |
arnau
force-pushed
the
avoid_snapshots_in_rsf_load
branch
from
b6d4ebe
to
648be07
Compare
arnau
force-pushed
the
avoid_snapshots_in_rsf_load
branch
2 times, most recently
from
8626345
to
bb14f3a
Compare
When the logs are collected in relaxed mode it does not need to compute the current snapshot for every single entry. This fix speeds up large registers by ~2x. Signed-off-by: Arnau Siches <arnau.siches@digital.cabinet-office.gov.uk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the logs are collected in relaxed mode it does not need to compute
the current snapshot for every single entry.
This fix speeds up large registers by ~2x.