This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
RFC0013: Multihash #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnau
force-pushed
the
multihash
branch
2 times, most recently
from
8f15057
to
87ad7d3
Compare
MatMoore
approved these changes
Aug 13, 2018
content/multihash/index.md
Outdated
|
|
||
| The proposal is to adopt [Multihash](https://multiformats.io/multihash/). | ||
| Their specification is quite thorough but the gist is to replace any of our | ||
| `sha-256:` to `1220`. `0x12` for the hashing function sha2-256 and `0x20` for |
There was a problem hiding this comment.
This confused me initially as I didn't realise you actually return the hex representation of the bytes as a string. I think you could leave out the hex representation here and just say "12" and "20".
There was a problem hiding this comment.
Umm, I see your point, I would like a way to express it such that it's clear 12 is in hex and not base 10 or something else. Any ideas?
This was referenced Aug 23, 2018
michaelabenyohai
approved these changes
Sep 4, 2018
added 3 commits
September 5, 2018 09:04
Signed-off-by: Arnau Siches <arnau.siches@digital.cabinet-office.gov.uk>
Signed-off-by: Arnau Siches <arnau.siches@digital.cabinet-office.gov.uk>
Signed-off-by: Arnau Siches <arnau.siches@digital.cabinet-office.gov.uk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently we use a custom
sha-256:prefix for stringified hexadecimal hashes to qualify them as SHA256. With this approach parsers must be done specifically for registers and registers must standarise as many hashing algorithms as needed by users.Changes proposed in this pull request
This RFC proposes to change the method to qualify hashes from using prefixes
sha-256:to using Multihash which is becoming a standard.Guidance to review
Check it is consistent.