-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for Windows #68
Conversation
@lippertmarkus Thank you for this contribution and sorry for not replying right away. I think the approach of using the upstream OpenResty binaries is best. I intend to eventually slim down the number of Dockerfiles and keep just the OpenResty binaries and a couple others. I will start setting up Appveyor for this. Some minor fixes / notes.... Add Add maintainer information as a label in the final image Does there really need to be three |
@neomantra Thanks for the feedback, I commited the changes. |
All the Appveyor builds are working and you should see both I note that they are 6 GB. Is that normal for a Windows Docker image? Is there some easy cleanup we can do? The OpenResty Windows download is only 12 MB. |
Perfect! You could update the image description on Docker Hub also (https://hub.docker.com/r/openresty/openresty/). Unfortunately this is normal, yes. The base Also we can't use the smaller (~500 MB) |
Docker Hub updated, thanks for the reminder and the info about Windows image sizes. |
To correct myself: It is possible to build 64 bit binary of nginx (e.g. http://kiyolee.blogspot.de/2012/04/building-nginx-120-with-64-bit-visual-c.html) but nginx doesn't officially provide them for downloading. |
@lippertmarkus Official OpenResty Win64 packages are already out: https://groups.google.com/d/msg/openresty-en/bTfqTjshcX4/uP8qF0EpAgAJ |
@agentzh Thanks for pointing this out! |
Yes, let's wait and coordinate with the official OpenResty release of 1.13.6.2. |
Adding Dockerfile for Windows. Unfortunately building OpenResty inside Docker during image build is currently not possible due to issues with MSYS2/Cygwin or similar environments (see docker/for-win#262).
Instead the Dockerfile is using the prebuilt binaries for Windows and also installs Perl. You can try the image on Windows:
I would recommend AppVeyor for CI on Windows. It worked flawlessly in my tests, is free for open-source software and easy to integrate: