forked from mpx/lua-cjson
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New test suite for all verions of Lua using GitHub actions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
leafo
force-pushed
the
leafo/github-actions-tests
branch
from
April 25, 2020 21:20
de4475e
to
55e3b9f
Compare
Github actions is now generally available so I'm merging this. (I also merged #49) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was writing #49 I wanted to update the test suite to reflect all versions of Lua. I think GitHub actions is probably the future of all CI on GitHub so I opted to go that direction. Sadly it's currently in beta. That means if this pull request is merged, the tests may not actually run until the OpenResty account gets whitelisted for the beta, or the feature is publicly launched (I think that's going to happen soon).
If you're an owner of the OpenResty org go here (you may get granted access immediately): https://github.com/features/actions/signup/
You can see a build here on my account: https://github.com/leafo/lua-cjson/commit/68e2a4a17026e826a661bb001cb86fce27771dc1/checks
The build matrix tests:
The following test are run:
runtests.sh
I tried to make my changes to the existing test suites as conservative as possible, since I don't know if anyone else is depending on them in other build pipelines. I think the entire setup is a huge mess though, and someone probably needs to maintain all the tests in one place for a future patch.
runtests.sh
for luajitThe command "cppcheck -i ./luajit2 -i --force --error-exitcode=1 --enable=warning . > build.log 2>&1 || (cat build.log && exit 1)" exited with 1.
. I fixed the issue on the github actions build