feature: Add api to fetch raw nginx ssl pointer #1286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-callahan
force-pushed
the
get_ssl_pointer
branch
from
349f8cc
to
45c2bed
Compare
|
Test seems to be failing for unrelated reasons. |
agentzh
requested changes
Mar 28, 2018
src/ngx_http_lua_ssl_certby.c
Outdated
| @@ -1319,6 +1319,21 @@ ngx_http_lua_ffi_set_priv_key(ngx_http_request_t *r, | |||
| } | |||
|
|
|||
|
|
|||
| int | |||
| ngx_http_lua_ffi_get_ssl_pointer(ngx_http_request_t *r, | |||
There was a problem hiding this comment.
We are moving to the meta-lua-nginx-module:
https://github.com/openresty/meta-lua-nginx-module
So this change deserves supporting other subsystems as well (like the stream subsystem) if we indeed want to have this.
There was a problem hiding this comment.
Won't this get added when the stream subsystem gains ssl_certificate_by_lua_block support?
src/ngx_http_lua_ssl_certby.c
Outdated
| { | ||
| if (r->connection == NULL || r->connection->ssl == NULL) { | ||
| *err = "bad request"; | ||
| return NGX_ERROR; |
There was a problem hiding this comment.
It's better to just return the SSL pointer directly and return NULL in case of errors.
james-callahan
force-pushed
the
get_ssl_pointer
branch
from
45c2bed
to
916a243
Compare
james-callahan
force-pushed
the
get_ssl_pointer
branch
2 times, most recently
from
e3ca94d
to
2abdfe2
Compare
james-callahan
force-pushed
the
get_ssl_pointer
branch
from
2abdfe2
to
319e8e0
Compare
|
Test added. |
|
Is there anything blocking this PR? |
This was referenced May 18, 2018
|
This pull request is now in conflict :( |
zhuizhuhaomeng
force-pushed
the
master
branch
from
f924579
to
fef2581
Compare
agentzh
requested changes
Jan 14, 2022
| @@ -1319,6 +1319,17 @@ ngx_http_lua_ffi_set_priv_key(ngx_http_request_t *r, | |||
| } | |||
|
|
|||
|
|
|||
| ngx_ssl_conn_t * | |||
| ngx_http_lua_ffi_get_ssl_pointer(ngx_http_request_t *r) | |||
There was a problem hiding this comment.
ngx_http_lua_ffi_get_req_ssl_ptr is a better name.
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows introspection of the
SSL*object from lua code.I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.