Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added new api function ngx.resolve which allows perform host… #1478

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slimboyfat
Copy link

@slimboyfat slimboyfat commented Feb 20, 2019

… name's resolution from Lua code using Nginx core's dynamic resolver.

Please, check my new FFI-based implementation. Lua-part (openresty/lua-resty-core#235)

Let me propose a new API function for Lua - ngx.resolve. This function relies on Nginx core's dynamic resolver. This approach has several advantages e.g: common query cache for Nginx core & Lua code with ability to customize caching policy by DNS TTL/custom timeout.

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

… name's resolution from Lua code using Nginx core's dynamic resolver.
src/ngx_http_lua_resolve.c Outdated Show resolved Hide resolved
src/ngx_http_lua_resolve.c Outdated Show resolved Hide resolved
src/ngx_http_lua_resolve.c Outdated Show resolved Hide resolved
README.markdown Outdated Show resolved Hide resolved
README.markdown Outdated Show resolved Hide resolved
README.markdown Outdated Show resolved Hide resolved
src/ngx_http_lua_resolve.c Outdated Show resolved Hide resolved
src/ngx_http_lua_resolve.c Outdated Show resolved Hide resolved
src/ngx_http_lua_resolve.c Outdated Show resolved Hide resolved
src/ngx_http_lua_resolve.h Outdated Show resolved Hide resolved
static void ngx_http_lua_resolve_empty_handler(ngx_resolver_ctx_t *ctx);
static ngx_int_t ngx_http_lua_resolve_resume(ngx_http_request_t *r);
static int ngx_http_lua_resolve_retval(ngx_http_lua_resolver_ctx_t *ctx,
lua_State *L);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation. See the guide for details:

https://openresty.org/en/c-coding-style-guide.html

Also, make sure you run the ngx-releng tool mentioned in the guide as well. That tool should catch this.

@mergify
Copy link

mergify bot commented Aug 23, 2021

This pull request is now in conflict :(

@mergify
Copy link

mergify bot commented Mar 20, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Mar 20, 2023
@mergify mergify bot removed the conflict label May 10, 2023
@mergify
Copy link

mergify bot commented May 10, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflict label May 10, 2023
@mergify mergify bot removed the conflict label Sep 23, 2023
@mergify
Copy link

mergify bot commented Sep 23, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Sep 23, 2023
@mergify mergify bot removed the conflict label Mar 6, 2024
Copy link

mergify bot commented Mar 6, 2024

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Mar 6, 2024
@mergify mergify bot removed the conflict label May 27, 2024
Copy link

mergify bot commented May 27, 2024

This pull request is now in conflict :(

@mergify mergify bot added the conflict label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants