feature: provide a way to reuse table in ngx.req.get_uri_args #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doujiang24
reviewed
Mar 25, 2020
There was a problem hiding this comment.
@spacewander I think it's safer to use table.clear inside this function.
|
@doujiang24 |
|
@spacewander LGTM, we need the doc for this change as you have mentioned. |
|
@doujiang24 |
zhuizhuhaomeng
approved these changes
Mar 4, 2022
|
@spacewander would you please rebase to the latest code and add the doc? |
spacewander
force-pushed
the
get_uri_args_tab
branch
from
9a3b70b
to
913e5e2
Compare
|
Already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add docs.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-resty-core project.