add support to custom headers during handshake #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentzh
requested changes
Nov 23, 2017
agentzh
reviewed
Nov 23, 2017
|
@agentzh please re-review :) |
|
@agentzh please let me know if there's anything needed from me here. |
agentzh
requested changes
Jan 23, 2018
Add support to custom headers in WS handshake.
agentzh
requested changes
Jan 23, 2018
agentzh
reviewed
Jan 23, 2018
|
Any reason this was never merged? I may have a use case where I also need the ability to add a custom rest Authentication header for the initial ws handshake as well. The application I connect to may accept access in form of a query parameter too though so if that is the case then it won't be needed, but this would be a nice to have feature in the core lib. |
newapplesho
approved these changes
Sep 1, 2019
|
@doujiang24 |
doujiang24
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing custom headers to WS handshake.