ARR - Adjusting review feedback from #2327
Conversation
|
Yes, we won't have time to deploy this for August - I'll modify the tests to reflect the new workflow. The tests are currently configured to have this open up after meta-reviews are released but would it be better for this to be open during the meta-reviewing stage? |
|
This should be released during the author response period. |
|
@haroldrubio Any status update here? We'd like to get it merged in before the October site is set up. Thanks! |
|
Also, what will the title of this be? Just 'Official Comment'? Or something else? Ideally, it would be different, so it is easy to identify. |
|
I've moved around the existing tests - you can see a preview of the form below. The form is called "Review Rating" by default Is the wording finalized? I'll need to update the tests another time and I can ask for reviews on the changes after that. |
|
Thanks, yes, the wording is finalised. One thing to check (that is not clear from the screenshot) - this should be a form that is optionally completed once per review. Is it clear which review it is attached to / about? |
|
Thanks so much for the screenshot, Harold! Would it be possible to rename that form to "Review Issue Report"? As you can see, there is no field there that can be interpreted as a rating, so this title might be confusing. |
…#2323) * Add autoapproval for some types of name deletion requests * Update request_remove_name_process.py Add return
Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com>
* check groups exist * fix test
* Fix: Pass program chairs group in an array * increase package version --------- Co-authored-by: Celeste Martinez <celeste@openreview.net>
* add get_group_edits to api2 client * let format_params take care of boolean
* Update postSubmissionProcess.py Add a notification that the post submission stage has completed * Update postSubmissionProcess.py Fix formatting of message * Update test_venue_request_v2.py Add draft of test to issue * Update test_icml_conference.py * Update test_icml_conference.py * Update test_icml_conference.py --------- Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com>
* add default to pending reviews invitation * send copy of invite email to AE * send invite assignment reminder 1 week after invitation is sent
* remove abstract process function * fix test
Co-authored-by: carlosmondra <carlos@openreview.net>
|
Two things: 1 - I was trying to make further edits and may have messed up merging etc. Sorry! Hopefully easy to resolve 2 - The thing I was adding was changes to the metareview form that go with this PR. One thing we don't have that is needed is limiting who can see certain fields in the metareview. I can see here how to do that for a single venue, but how can I do it generically? To be specific, we want the following fields in the metareview to have the following visibility: Authors, AC, SAC, PC
AC, SAC, PC
|
|
@haroldrubio could you confirm when this would be merged? I'm an EiC for this cycle, and we need to publish the new version of reviewer instructions asap, and the instructions assume that this new process is in place. |
|
Hi @annargrs we'll be able to get this ready for this cycle, I'll ask for another review and hopefully we could get this merged next week |
| "review_rating_start_date": { | ||
| "description": "When should the review rating form open?", | ||
| "review_issue_start_date": { | ||
| "description": "When should the form for authors to make sturctured complaints to ACs about reviews open?", |
There was a problem hiding this comment.
| "description": "When should the form for authors to make sturctured complaints to ACs about reviews open?", | |
| "description": "When should the form for authors to make structured complaints to ACs about reviews open?", |
| "review_rating_exp_date": { | ||
| "description": "When should the review rating form close?", | ||
| "review_issue_exp_date": { | ||
| "description": "When should the form for authors to make sturctured complaints to ACs about reviews close?", |
There was a problem hiding this comment.
| "description": "When should the form for authors to make sturctured complaints to ACs about reviews close?", | |
| "description": "When should the form for authors to make structured complaints to ACs about reviews close?", |
| ], | ||
| "type": "integer" | ||
| "optional": True, |
There was a problem hiding this comment.
should this checkbox be "deletable": True as well?
There was a problem hiding this comment.
I believe all fields that are options should also be deletable, in case a checkbox was clicked by mistake and the author wants to uncheck it.
The ARR EICs have designed a new review feedback from (effort led by @annargrs). I've updated the form itself and the description of the date fields in the venue configuration (so it is clear to future EICs what those dates are for).
Is there any chance this can be applied to the August 2024 ARR venue? The idea would be to make the form accessible to authors in late October. I completely understand if the answer is no, since the venue is live already, but wanted to check.
Thanks!