Test using different characters in role names #2367
Draft
+397
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea! |
|
edge browser is failing because of url encoding |
|
please try openreview/openreview-web#2115 |
|
when pre-process of assignment invitation check for quota, it's looking for |
xkopenreview
reviewed
Oct 4, 2024
| @@ -1723,7 +1723,7 @@ def pretty_id(group_id): | |||
| transformed_token=re.sub('\..+', '', token).replace('-', '').replace('_', ' ') | |||
| letters_only=re.sub('\d|\W', '', transformed_token) | |||
|
|
|||
| if letters_only != transformed_token.lower(): | |||
| if not (letters_only == letters_only.lower() and letters_only != letters_only.upper()): | |||
There was a problem hiding this comment.
similar change as in openreview/openreview-web#2115
xkopenreview
reviewed
Oct 4, 2024
| @@ -994,6 +994,7 @@ def set_meta_review_invitation(self): | |||
| if self.venue.use_senior_area_chairs: | |||
| # Build SAC acronym | |||
| sac_acronym = ''.join([s[0].upper() for s in self.venue.senior_area_chairs_name.split('_')]) | |||
| sac_acronym = sac_acronym if sac_acronym.isascii() else 'SAC' | |||
There was a problem hiding this comment.
i think sometimes acronym may not be meaningful
xkopenreview
reviewed
Oct 4, 2024
| @@ -1089,7 +1089,8 @@ def setup_invite_assignment(self, hash_seed, assignment_title=None, due_date=Non | |||
| 'hash_seed': { 'value': hash_seed, 'readers': [ venue.venue_id ]}, | |||
| 'email_template': { 'value': email_template if email_template else ''}, | |||
| 'is_reviewer': { 'value': True if (self.match_group.id.split('/')[-1] in venue.reviewer_roles) else False }, | |||
| 'is_ethics_reviewer': { 'value': True if self.match_group.id == venue.get_ethics_reviewers_id() else False } | |||
| 'is_ethics_reviewer': { 'value': True if self.match_group.id == venue.get_ethics_reviewers_id() else False }, | |||
| 'reviewer_name': { 'value': venue.get_reviewers_name(pretty=False) } | |||
There was a problem hiding this comment.
save in content so venue.py can use it in ln1423
|
icml test should pass with this pr and openreview/openreview-web#2117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for testing, not meant to be merged.
Changes the role names to use Japanese characters. Currently breaks around Line 1676 when asserting the edge browser url.
Update:
Commented out edge browser url assertions because the url encoding is different for these characters.
Now the tests break at Line 1681. Not sure why yet, I could have missed a name replacement or there could be another issue. I think it should be tested further.