Remove hardcoded names in urls #2025
Conversation
|
the console tests require some update |
|
Looking back, I think there are some changes that aren't necessary, at least for this PR. For example, I don't think any of these values are displayed in the URLs, but I'm not certain: |
i think you are right |
|
i think the pc console should have a default tab (for example overview tab) when the location hash is not a valid tab id implementation can refer to sac console which always default to submission status tab when location hash is not a valid tab id |
|
i think ln 1136 of pc console
is causing the submissionContentFields panel to fail to load when url already has the hash |
|
i feel the Console tabs should be extracted out so it can be properly tested |
| @@ -1101,7 +1133,7 @@ const ProgramChairConsole = ({ appContext, extraTabs = [] }) => { | |||
| <Tab | |||
| id={fieldAttrs.field} | |||
| key={fieldAttrs.field} | |||
| active={activeTabId === fieldAttrs.field ? true : undefined} | |||
| active={activeTabId === `#${fieldAttrs.field}` ? true : undefined} | |||
There was a problem hiding this comment.
causing the submissionContentFields panel to fail to load when url already has the hash
@xkopenreview I think this was because we weren't adding # in front of the field here. I reproduced it in my local and the panel loads now.
* Fix roles in urls, use consistent naming in tabs * Fix AC console tests * Fix reviewer console tests * Fix SAC console tests * Revert changes to modal ids * Add default tab for PC console * Remove screen debug in test * Fix valid tab IDs and submission content tabs in PC console * Move role name formatting to util function --------- Co-authored-by: xkopenreview <60613434+xkopenreview@users.noreply.github.com> Co-authored-by: Melisa Bok <545506+melisabok@users.noreply.github.com>
This PR removes hardcoded names from the hashes in URLs and makes tab naming consistent.
For ex: changes
#areachair-tasksto#area-chair-tasks