Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ Invitation revisions page - edit to remove process function is not displayed correctly #2103

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix/ Invitation revisions page - edit to remove process function is not displayed correctly #2103

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1050b7
revisions show empty value; remove group web trim
xkopenreview Sep 19, 2024
3e73bbd
Merge branch 'master' into fix/revisions-empty-value
xkopenreview Sep 26, 2024
b78f05c
Merge branch 'master' into fix/revisions-empty-value
xkopenreview Oct 1, 2024
58eac30
Merge branch 'master' into fix/revisions-empty-value
xkopenreview Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/Edit/EditContentValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ const EditContentValue = ({ editId, fieldName, fieldValue, enableMarkdown, isJso
) {
return (
<div className="note-content-value">
<pre>{fieldValue}</pre>
{fieldValue.length ? (
<pre>{fieldValue}</pre>
) : (
<span className="empty-value">(empty)</span>
)}
</div>
)
}
Expand Down
2 changes: 1 addition & 1 deletion components/group/GroupUICode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const GroupUICode = ({ group, profileId, accessToken, reloadGroup }) => {
const requestBody = {
group: {
id: group.id,
web: modifiedWebCode.trim() ? modifiedWebCode.trim() : null,
web: modifiedWebCode,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to convert space to empty string because empty string is not allowed
to make it consistent with invitation editor

},
readers: [profileId],
writers: [profileId],
Expand Down