Feature/ Consoles - Extract console tabs into components #2189
Conversation
| <ConsoleTabs | ||
| defaultActiveTabId="overview" | ||
| tabs={[ |
There was a problem hiding this comment.
The AC and Reviewer console have updateActiveTabId={setActiveTabId} set, do we not need this for the other consoles?
There was a problem hiding this comment.
for AC and reviewer console the activaTabId is required to construct the referrer link so that user can go back to the same tab
for ethics chair console it's fixed to be paper status tab
[Ethics Chair Console](/group?id=${venueId}/${ethicsChairsName}#${submissionName.toLowerCase()}-status)so i think it's not required
components/webfield/ConsoleTabs.js
Outdated
| if (!validTabIds.includes(activeTabId)) { | ||
| setActiveTabId(defaultActiveTabId) | ||
| updateActiveTabId?.(`#${defaultActiveTabId}`) | ||
| return | ||
| } |
There was a problem hiding this comment.
Do we need to call updateActiveTabId here? I think when setActiveTabId is called it will trigger useEffect again with a valid (default) tab, so the parent's state would already get updated in line 20 with the default. What do you think?
There was a problem hiding this comment.
i think you are right
|
this pr does not require change for next upgrade |
this pr should consolidate the tabs and active tab logic to a separate component so that related logic are not duplicated in all consoles and can be better tested