Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the dependencycheck plugin #30

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

lkerford
Copy link
Contributor

@lkerford lkerford commented Jan 1, 2025

The vulnerability-analysis github action is failing to run because this repository doesn't have the dependencyCheckAggregate task. This task is provided by the org.owasp.dependencycheck gradle plugin

Github action output: https://github.com/moderneinc/dependency-vulnerability-reports/actions/runs/12570425807/job/35040333841#step:7:1

The vulnerability-analysis github action is failing to run because this repository doesn't have the `dependencyCheckAggregate` task. This task is provided by the `org.owasp.dependencycheck` gradle plugin
@timtebeek
Copy link
Contributor

Had a brief look; had expected this to come in through
https://github.com/openrewrite/rewrite-build-gradle-plugin/blob/f6a807e1b84cae9bcad8c6f3170fcba8b1120218/src/main/java/org/openrewrite/gradle/RewriteDependencyCheckPlugin.java#L37

But then it seems we've copied the multi module approach here from openrewrite/rewrite, where we also explicitly add owasp again, likely because we do not use org.openrewrite.build.recipe-library in either of those.

@lkerford
Copy link
Contributor Author

lkerford commented Jan 1, 2025

The vulnerability-analysis github action is failing to run because this repository doesn't have the dependencyCheckAggregate task. This task is provided by the org.owasp.dependencycheck gradle plugin

ya, most of the repositories are getting the plugin from the org.openrewrite.build.recipe-library but not everything uses it

@lkerford lkerford merged commit f77e86d into main Jan 1, 2025
2 checks passed
@lkerford lkerford deleted the adding-dependencycheck branch January 1, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants