Migrate DateMidnight creation
#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/joda/time/templates/DateTimeMidnightTemplates.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
MBoegers
commented
Nov 10, 2025
Contributor
Author
|
|
timtebeek
approved these changes
Nov 10, 2025
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add migration from
DateMidnighttoLocalDatefixing time to start of day.Also I am very brutally change the type for
LocalDates.What's your motivation?
Enable migration path for codebases using
DateMidnight.Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
A first version did not integrate with the existing visitors structures. I sticked with trhe current pattern as there is an onhgoing rework and I don't want to infer here with a third approach.
Any additional context
Seen this in customer projects and and we came up with this path.
Checklist