Printable Recipe Datatables #751
Conversation
|
|
||
| if (exportDatatables) { | ||
| String timestamp = LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyy-MM-dd_HH-mm-ss-SSS")); | ||
| Path datatableDirectoryPath = Paths.get("target/rewrite/", "datatables", timestamp); |
There was a problem hiding this comment.
Can you use Paths.get("target", "rewrite", "datatables", timestamp); here instead? Might be safer for Windows users.
There was a problem hiding this comment.
Yep, good catch. Corrected.
There was a problem hiding this comment.
So just to chime in, the Windows FileSystem implementation accepts both forward and back slashes without any issues. A *nix based FileSystem will only accept forward slashes, so either always using forward slashes, letting the filesystem choose (as illustrated by @ammachado), or using File.separatorChar are all valid solutions that work across OS boundaries.
|
@timtebeek Is there anything else needed to get this merged? |
|
hi @ryan-hudson thanks for the work! I've been out for a couple weeks, with a bit more travel to go still. Perhaps @knutwannheden or @sambsnyd can have a look. |
|
@timtebeek Bumping this again for visibility. It would be great to have this reviewed and merged! |
…o into new AbstractRewriteBaseRunMojo abstract class. The extension path for the Abstract Run and Dry Run Mojos is now: AbstractRewriteRunMojo/AbstractRewriteDryRunMojo -> AbstractRewriteBaseRunMojo -> AbstractRewriteMojo
src/main/java/org/openrewrite/maven/AbstractRewriteBaseRunMojo.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim te Beek <timtebeek@gmail.com>
Yep, purely copy paste work. No intentional changes to any of the moved methods. |
There was a problem hiding this comment.
Thanks a lot @ryan-hudson for the work both here and in
Should be need to see what others will build with data tables.
/cc @mike-solomon data tables are now no longer unique to Moderne, so we might want to document how to use this in OpenRewrite as well, as we have done for Moderne.
What's changed?
Adds rewrite.exportDatatables property to Maven Plugin to allow Datatable information to be exported as a CSV.
See the Rewrite-Core PR for more information.
Anything in particular you'd like reviewers to focus on?
Note that the datatable output path is currently set to target/rewrite/datatables
These changes are dependent on the changes in this rewrite-core pr