Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe for migration JakartaEE Security is wrong #160

Closed
mabartos opened this issue Jan 5, 2023 · 1 comment · Fixed by #161
Closed

Recipe for migration JakartaEE Security is wrong #160

mabartos opened this issue Jan 5, 2023 · 1 comment · Fixed by #161
Assignees
@tkvangorder

Comments

@mabartos
Copy link
Contributor

mabartos commented Jan 5, 2023

Packages in our codebase were changed from javax.security.* to jakarta.security.* even though any dependency of javax.security.enterprise is included in the project.

The security packages javax.security.* are included in the JDK itself, and for JDK 11, it still contains the prefix javax.*, so probably these packages should not be updated in the codebase.

If we specify the required packages more, we'll avoid unnecessary collisions.

Issue to OpenRewrite docs: openrewrite/rewrite-docs#111

See: quarkusio/quarkus#30198
keycloak/keycloak#16247
mabartos added a commit to mabartos/rewrite-migrate-java that referenced this issue Jan 5, 2023
@mabartos
Recipe for migration JakartaEE Security is wrong
9ef0b15 
Fixes openrewrite#160
This was referenced Jan 5, 2023
Merged
Closed
Closed
Closed
jkschneider added a commit that referenced this issue Jan 6, 2023
@mabartos @jkschneider
Recipe for migration JakartaEE Security is wrong (#161)
04618d3 
* Recipe for migration JakartaEE Security is wrong

Fixes #160

* Update jakarta-ee-9.yml

Co-authored-by: Jonathan Schnéider <jkschneider@gmail.com>
@tkvangorder
Copy link
Contributor

tkvangorder commented Jan 6, 2023 •
edited
Loading

@mabartos Thank you for reporting this.

I am going to open re-open this, as there is more to do in this area:

  • We need a recipe for Jakarta Authorization API.
  • We need a recipe for Jakarta Authentication API.

Look for a PR shortly.

@tkvangorder tkvangorder reopened this Jan 6, 2023
@github-project-automation github-project-automation bot moved this from Done to Backlog in OpenRewrite Jan 6, 2023
@tkvangorder tkvangorder self-assigned this Jan 6, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Jan 6, 2023
@mabartos mabartos mentioned this issue Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkvangorder tkvangorder

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recipe for migration JakartaEE Security is wrong mabartos/rewrite-migrate-java
2 participants
@tkvangorder @mabartos