Replace lombok.val with final var on projects using Java 11 or higher

[timtebeek]

Figured this would be a fun one, and learning exercise. It replaces lombok.val with final var, as there's not a lot of value in retaining lombok.val nowadays. As a bonus it makes projects more compatible with OpenRewrite, at least until there's integrated support.

Only thing that I'm not yet sure how to resolve is the tests containing infix whitespace & comment. Some guidance there would be appreciated once again. My attempts at using maybeAutoFormat failed up to now.

Fixes projectlombok/lombok#3207
Fixes openrewrite/rewrite#1297

TODO

• Reference from META-INF yaml
• Either fix or ignore infix whitespace & comments

[timtebeek]

Wasn't entirely sure whether this recipe would fit in best here or in openrewrite/rewrite. My guess was here as it's most applicable for users upgrading between Java versions.

[pway99]

Thanks Tim!

The recipe should also account for the case where lombok.val types are used in for-each statements

List<String> lst = new ArrayList<>();
for (val s : lst) {}

If you would like, I've got your PR loaded up and am happy to help with these changes :)

[timtebeek]

If you would like, I've got your PR loaded up and am happy to help with these changes :)

Yes please! Just arrived in Stavanger, so won't get to it myself otherwise for another week. Feel free to change it however you feel is best!

[pway99]

Well, It turns out the changes were not that simple after all... I discovered a Javatemplate BlockStamentGenerator bug which was preventing for-each loop transformations. I'll add some changes to your PR and merge them in after PR is merged.

[pway99]

Hi Tim, I've managed to get this merged in and will test it on the SaaS if everything looks good I will add a reference to the appropriate META-INF yaml file. Thanks again for your help on this one :)

[timtebeek]

Thanks for the fixes & merge! The bug in JavaTemplateBlockStatementGenerator would have surely tripped me up, so I'm glad you were able to dive into this one. Curious to hear what effects you see on SaaS! :)