Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDeprScan release 17 #127

Merged
merged 2 commits into from
Oct 17, 2022
Merged

JDeprScan release 17 #127

merged 2 commits into from
Oct 17, 2022

Conversation

timtebeek
Copy link
Contributor

Figured for Java 17 we'd want bump the release to Java 17.
Would AddPlugin also change the configuration if already present?
Noticed there's no tests for this recipe yet; could be added if needed.

tkvangorder
tkvangorder approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@tkvangorder tkvangorder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkvangorder tkvangorder merged commit c364748 into openrewrite:main Oct 17, 2022
@timtebeek timtebeek deleted the jdeprscan-17 branch October 17, 2022 16:50
@tkvangorder tkvangorder added this to the 1.13.0 milestone Oct 21, 2022
@tkvangorder tkvangorder added the enhancement New feature or request label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkvangorder tkvangorder tkvangorder approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @tkvangorder