Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 11 and 17 recipes now handle explicit (non-property) maven-compiler-plugin source/target/release configuration (preferring release) #149

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Java 11 and 17 recipes now handle explicit (non-property) maven-compiler-plugin source/target/release configuration (preferring release) #149

merged 3 commits into from
Dec 7, 2022

Conversation

nmck257
Copy link
Contributor

@nmck257 nmck257 commented Dec 7, 2022 •
edited
Loading

#37

@nmck257
Java 11 and 17 recipes now handle explicit (non-property) maven-compi…
1353d23 
…ler-plugin source/target/release configuration (preferring release)
@nmck257
fixed project description, and pinned apache commons deps to specific…
9799045 
… major versions to avoid resolving to versions like 20030203.000550
tkvangorder
tkvangorder approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@tkvangorder tkvangorder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nmck257 , looks good.

@tkvangorder tkvangorder added the recipe Recipe requested label Dec 7, 2022
@tkvangorder tkvangorder merged commit a17cf26 into openrewrite:main Dec 7, 2022
@nmck257 nmck257 deleted the feature/maven-compiler-explicit-config branch December 7, 2022 17:36
@tkvangorder tkvangorder added this to the 1.15.0 milestone Dec 13, 2022
@timtebeek timtebeek mentioned this pull request Sep 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkvangorder tkvangorder tkvangorder approved these changes

Assignees
No one assigned
Labels
recipe Recipe requested
Projects
OpenRewrite
Archived in project
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nmck257 @tkvangorder