Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inputstream finalizer #245

Merged
merged 12 commits into from
Jul 27, 2023
Merged

Remove inputstream finalizer #245

merged 12 commits into from
Jul 27, 2023

Conversation

satvika-eda
Copy link
Contributor

@satvika-eda satvika-eda commented Jun 27, 2023 •
edited
Loading

What's changed?

finalize method has been removed from the FileInputStream and FileOutputStream of the io package for which the needed automation has been done as part of the recipe created

What's your motivation?

To automate JDK migration to a greater extent

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@timtebeek timtebeek added the recipe Recipe requested label Jun 27, 2023
@timtebeek timtebeek self-requested a review June 27, 2023 10:09
timtebeek
timtebeek reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! A question and suggestion before we merge.

@satvika-eda
Copy link
Contributor Author

Thank you for your detailed inputs. I've made the necessary changes. Please review them.

@timtebeek timtebeek requested a review from knutwannheden July 6, 2023 08:36
knutwannheden
knutwannheden reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I added a few small review comments.

@timtebeek timtebeek requested a review from joanvr July 12, 2023 10:12
timtebeek
timtebeek approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started @satvika-eda !

@joanvr Would you mind having another look for a review of my changes? That way it's not just me.

joanvr
joanvr approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@joanvr joanvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've specially looked at the tests, and I thing we have a very good coverage! Good job!

@joanvr joanvr merged commit bb41637 into openrewrite:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden left review comments

@joanvr joanvr joanvr approved these changes

@timtebeek timtebeek timtebeek approved these changes

Assignees

@satvika-eda satvika-eda

Labels
recipe Recipe requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satvika-eda @knutwannheden @joanvr @timtebeek