Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting MaybeAddJakartaServletApi to be a ScanningRecipe so that … #255

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

nmck257
Copy link
Contributor

@nmck257 nmck257 commented Jul 10, 2023

…it can correctly apply its precondition to the AddDependency recipe

What's your motivation?

closes #254

Any additional context

Thinking about the introduction of ScanningRecipes, this is an example of a recipe which "wants" to be a non-scanning recipe but is trying to call a ScanningRecipe, and therefore itself becomes a ScanningRecipe

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • [ ] I've updated the documentation (if applicable)

…it can correctly apply its precondition to the `AddDependency` recipe
@nmck257
Copy link
Contributor Author

nmck257 commented Jul 10, 2023

thanks @sambsnyd -- the build has passed and i don't have write access here if you're good to merge this, too

@sambsnyd sambsnyd merged commit c5383a5 into openrewrite:main Jul 10, 2023
@nmck257 nmck257 deleted the bugfix/254 branch July 10, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

MaybeAddJakartaServletApi - does not actually respect its DoesNotIncludeDependency precondition
2 participants