Fix errors for Arrays and inception bounds #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBoegers
changed the title
timtebeek
reviewed
Jul 19, 2023
src/test/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericsConstructorsTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericsConstructors.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericsConstructors.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jul 19, 2023
src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericMethodInvocations.java
Show resolved
Hide resolved
timtebeek
approved these changes
Jul 20, 2023
|
Thanks again! Really appreciate how involved you are with seeing this one through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixed two additional edge cases in
UseVarForGenericsConstructorsfound with run moderne.io/results/CuzcKWhat's your motivation?
Fix edgecases in UseVarForGenericsConstructors.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
It breaks moderne.io runs, so no.
Any additional context
Checklist
./gradlew licenseFormatI've updated the documentation (if applicable)