Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate javax.annotation.Nullable to jakarta.annotation.Nullable #266

Merged

Conversation

rickie
Copy link
Contributor

@rickie rickie commented Aug 2, 2023

What's changed?

Introduced support for migrating javax.annotation.Nullable to jakarta.annotation.Nullable.

What's your motivation?

When running this recipe on our internal codebase at Picnic we noticed that the javax.annotation.Nullable annotation is not being migrated to jakarta.annotation.Nullable. After some investigation it was clear that this annotation was simply missing from this recipe.

Anyone you would like to review specifically?

@timtebeek

Any additional context

To test this change, I used the ./gradlew publishToMavenLocal command and ran the recipe locally. With this change it does work and I get the following diff (random example):

+import jakarta.annotation.Nullable;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.stream.Stream;
-import javax.annotation.Nullable;

@timtebeek timtebeek self-requested a review August 2, 2023 12:25
@timtebeek timtebeek added the recipe Recipe requested label Aug 2, 2023
@timtebeek
Copy link
Contributor

Much appreciated!

@timtebeek timtebeek merged commit d4f91fd into openrewrite:main Aug 2, 2023
@rickie rickie deleted the rossendrijver/javax-annotation-nullable branch August 2, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants