Apache Commons File Utils Migrations #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Aug 18, 2023
|
|
||
| @AfterTemplate | ||
| void after(File file, CharSequence data, Charset cs) throws Exception { | ||
| Files.write(file.toPath(), Arrays.asList(data), cs); |
There was a problem hiding this comment.
@knutwannheden (no rush! just interesting)
This fails compile in the generated recipe due to
java: reference to compile is ambiguous
both method compile(org.openrewrite.java.JavaVisitor<?>,java.lang.String,org.openrewrite.java.JavaTemplate.P3<?,?,?>) in org.openrewrite.java.JavaTemplate
and method compile(org.openrewrite.java.JavaVisitor<?>,java.lang.String,org.openrewrite.java.JavaTemplate.F3<?,?,?,?>) in org.openrewrite.java.JavaTemplate match
There was a problem hiding this comment.
Any idea what might be going on here? The generated code is:
final JavaTemplate before = JavaTemplate.compile(this, "before", (java.io.File file, CharSequence data, java.nio.charset.Charset cs) -> FileUtils.write(file, data, cs)).build();
final JavaTemplate after = JavaTemplate.compile(this, "after", (java.io.File file, CharSequence data, java.nio.charset.Charset cs) -> Files.write(file.toPath(), Arrays.asList(data), cs)).build();There was a problem hiding this comment.
We can work around this with a simple cast of course. ;/
There was a problem hiding this comment.
Haven't looked at it yet. Possibly we need to generate an explicit cast, because the return type of the called method is not void like that of the template method.
timtebeek
reviewed
Aug 18, 2023
src/test/java/org/openrewrite/java/migrate/apache/commons/io/ApacheCommonsFileUtilsTest.java
Show resolved
Hide resolved
timtebeek
reviewed
Aug 18, 2023
AlekSimpson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds two refaster templates to migrate
FileUtilsmethods.What's your motivation?
Moving onto
FileUtilsafter StringUtilsAnything in particular you'd like reviewers to focus on?
So currently it won't build because the
Writetemplate is a little off. I think the reason its failing with this one is thatFileUtils.write()returns void while Java's write methodFiles.write()returns a Path. I don't think there are any other one line method Java provides to write to a file. Will we just not be able to do migrations forFileUtils.write()because of this?Anyone you would like to review specifically?
@timtebeek
Checklist
./gradlew licenseFormat