Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and reformatting for line length. #276

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

mlvandijk
Copy link
Contributor

What's changed?

Fixed some typos / grammatical errors in the README and reformatted for line length

What's your motivation?

Small improvements to the README

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me; asked @mike-solomon to optionally have another look before a merge.

@timtebeek timtebeek added the documentation Improvements or additions to documentation label Aug 21, 2023
Copy link
Contributor

@mike-solomon mike-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping documentation in mind and making these changes! I went through and made some additional grammar suggestions to the text (which was definitely not your fault to be clear!)

Co-authored-by: Mike Solomon <mikesol@hey.com>
@timtebeek timtebeek merged commit eddbad3 into openrewrite:main Aug 21, 2023
@mlvandijk
Copy link
Contributor Author

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants