Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade maven-compiler-plugin to 3.6.2 to support <release> tag. #281

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Upgrade maven-compiler-plugin to 3.6.2 to support <release> tag. #281

merged 1 commit into from
Aug 30, 2023

Conversation

nguyenhoan
Copy link
Contributor

@nguyenhoan nguyenhoan commented Aug 29, 2023 •
edited by timtebeek
Loading

What's changed?

Upgrade maven-compiler-plugin to 3.6.2 to support <release> tag.

What's your motivation?

Fixes #279

Anyone you would like to review specifically?

@knutwannheden

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've used the IntelliJ IDEA auto-formatter on affected files

@nguyenhoan nguyenhoan mentioned this pull request Aug 29, 2023
Closed
@timtebeek timtebeek assigned timtebeek and nguyenhoan and unassigned timtebeek Aug 30, 2023
@timtebeek timtebeek added bug Something isn't working enhancement New feature or request recipe Recipe requested labels Aug 30, 2023
knutwannheden
knutwannheden approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@knutwannheden
Copy link
Contributor

Thanks for the contribution!

@knutwannheden knutwannheden merged commit e975008 into openrewrite:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden approved these changes

Assignees

@nguyenhoan nguyenhoan

Labels
bug Something isn't working enhancement New feature or request recipe Recipe requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible use of <release> parameter in the configuration of maven-compiler-plugin
3 participants
@nguyenhoan @knutwannheden @timtebeek