Added 4 new Java 11 recipes #300
Conversation
| type: specs.openrewrite.org/v1beta/recipe | ||
| name: org.openrewrite.java.migrate.JREDoNotUseSunNetSslInternalWwwProtocolHttpsHandler | ||
| displayName: Use `com.ibm.net.ssl.www2.protocol.https.Handler` instead of `com.sun.net.ssl.internal.www.protocol.https.Handler` | ||
| description: Do not use the com.sun.net.ssl.internal.www.protocol.https.Handler class. | ||
| tags: | ||
| - java11 | ||
| recipeList: | ||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.sun.net.ssl.internal.www.protocol.https.Handler | ||
| newFullyQualifiedTypeName: com.ibm.net.ssl.www2.protocol.https.Handler | ||
| ignoreDefinition: true |
There was a problem hiding this comment.
I'm doubting if we should migrate folks over to the ibm classes; would those not be constrained to a particular JVM vendor or dependency?
Curious to hear your thoughts as I might lack some background.
There was a problem hiding this comment.
This is one of the recipes I mentioned would be IBM-specific. It's possible other solutions exist, but this is one we provided an alternative for. This recipe would really be aimed at our customers. If you want I can remove the recipe from the general Java 11 list.
There was a problem hiding this comment.
I think removing it from the java-version-11.yml would be best indeed; would it fit in better with rewrite-liberty perhaps? Or would you think a separate IBM, OpenJ9 or Semuru yml file would fit in best here?
There was a problem hiding this comment.
A separate ibm-java yml would be a better fit.
There was a problem hiding this comment.
I'll push that update soon. I hadn't gotten a chance to revisit this PR until today. I just noticed that the build is passing now. Thanks for helping me work out those issues.
|
For whatever reason, the 2 tests I mentioned in the description are still failing locally. It seems like there is something about my environment I'll need to fix. That is something I'll need to investigate further later. |
|
Thanks again! :) |
|
Thanks Kun! How can I kick off a new build when your fix goes live? |
|
The fix will need a while to go live, I think we can merge this directly, and I will re-run the build ~1 hour later to make sure it's green. |
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
There seems to still be issues with the
testJREDoNotUseSunNetSslInternalSslProviderandtestJREDoNotUseSunNetSslInternalWwwProtocolHttpsHandlertests. It seems like the dependencies provided insun.internal.jararen't resolving properly despite the code compiling properly in a live environment using that jar. Feel free to look into that issue with me.Anyone you would like to review specifically?
@timtebeek @joanvr
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew licenseFormat