J2ee10 - remove_parm soap_element_factory recipes

[ranuradh]

What's changed?

## What's your motivation?

Anything in particular you'd like reviewers to focus on?

@timtebeek @joanvr

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ IDEA auto-formatter on affected files

[joanvr]

I'm seeing a failed test, missing a recipe called org.openrewrite.java.migrate.jakarta.RemoveNewInstance?

missing recipe

[joanvr]

why we have this file? I've checked the contents and it's just a Test1 class that it's not being used and a stub for MethodExpression. Why don't we add the actual jakarta.el-api jar or add the stub in the test itself?

[ranuradh]

yes we can use the jakarta.el-api.jar instead

[joanvr]

what's the purpose of this extra stuff in the test?

[ranuradh]

This extra stuff was just to ensure nothing happened to it and I have used it as a negative test..

[joanvr]

After a bit more of diving into the recipe:
SOAPElementFactory.newInstance() method has no direct replacement but probably should be replaced by SOAPFactory.newInstance() when you are replacing the whole type?
I'm not sure about this part of the recipe

[joanvr]

Pushed some changes:

• Improved format on tests
• Removed unnecessary bits on tests
• Removed multiple versions of jakarta.xml.soap-api
• Added jakarta.el-api
• Removed recipe that removes SOAPElementFactory.newInstance() -> Instead just let it be changed to SOAPFactory.newInstance()

Can you take a look at it and discuss about it?

[ranuradh]

I approve the slight test changes and adding the .jars. ,Regarding The static method SOAPElementFactory.newInstance() is removed without replacement. See the Jakarta EE 9.1 documentation. I thought we needed to remove it not replace it .Since the documentation doesn't ask us to replace it and our rule description asks us to remove without replacement. I guess we could replace it with the SOAPFactory.newInstance(). Just checked this would be fine..Could we merge your changes.Thanks!

[joanvr]

Merged! Thank you very much for your time and contributions @ranuradh :)

[ranuradh]

Thanks a ton @joanvr!