Adds MXbean recipe #335
Merged
Adds MXbean recipe #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Nov 6, 2023
Comment on lines
+137
to
+138
| public | ||
| interface Foo { |
There was a problem hiding this comment.
Not quite sure where this extra newline comes from; ideally we have that removed before a merge, but since this will likely only affect a small number of interfaces I can also see that as a future improvement.
There was a problem hiding this comment.
Haha yeah, I wasn't able to determine the cause. I was hoping you might know.
There was a problem hiding this comment.
Yeah I tried for a bit to figure out a way to fix it; but in the end thought it not worth spending considerable amount of time on, if we're not even sure it replicates beyond this test.
timtebeek
reviewed
Nov 6, 2023
src/test/java/org/openrewrite/java/migrate/MXBeanNonPublicTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 6, 2023
src/test/java/org/openrewrite/java/migrate/MXBeanNonPublicTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 6, 2023
src/test/java/org/openrewrite/java/migrate/MXBeanNonPublicTest.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek @joanvr
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew licenseFormat