Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand ListFirstAndLast covered cases to include getList().get(0) #424

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Feb 21, 2024

What's your motivation?

Fixes #423

Anything in particular you'd like reviewers to focus on?

There's still a strong overfit here in:

  1. only looking at identifiers (mostly)
  2. only supporting getFirst() for method invocations

Have you considered any alternatives or workarounds?

Likely iterate to reduce the overfit.

Any additional context

Would be nice to run these tests in CI, finally

@timtebeek timtebeek added the bug Something isn't working label Feb 21, 2024
@timtebeek timtebeek self-assigned this Feb 21, 2024
@timtebeek timtebeek marked this pull request as ready for review February 21, 2024 23:08
@timtebeek
Copy link
Contributor Author

@timo-abele Would appreciate a review on this, also to see if there's more cases you can think of.

Copy link

@timo-abele timo-abele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the recipe on my code base, now only lombok generated getters (which we heavily use) are ignored.

@timtebeek
Copy link
Contributor Author

Thanks for trying it out! Indeed Lombok support remains in issue, but at least good that we can cover more cases already now.

@timtebeek timtebeek merged commit 367e4fe into main Feb 22, 2024
2 checks passed
@timtebeek timtebeek deleted the expand-ListFirstAndLast-covered-cases branch February 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ListFirstAndLast skips methodCall().get(0)
2 participants