Replace Reference.clone() with new constructor in Java 11 migration
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/migrate/ReferenceCloneMethodTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/ReferenceCloneMethodTest.java
Show resolved
Hide resolved
…radh/rewrite-migrate-java into recipe_ReferenceCloneMethod
…dTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…dTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
changed the title
Reference.clone() with new constructor in Java 11 migration
src/main/java/org/openrewrite/java/migrate/ReferenceCloneMethod.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Thanks for the new recipe @AnuRam123 ; good to see you back!
I've made some changes to your recipe to also clear out the fully qualified types, and remove the type casts that are no longer necessary with the new constructors. Hope you agree!
|
Thanks @timtebeek yes I was looking into TypeCast and wasn't sure how to go about it. This recipe is now perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR contains recipe:
org.openrewrite.java.migrate.ReferenceCloneMethod
This rule:
What's your motivation?
The custom recipe, replaces the calls to
java.lang.ref.Reference.clone()with a constructor call passing in the referent and reference queue as parameters.Anyone you would like to review specifically?
@timtebeek
@cjobinabo
Checklist