-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Guava Immutable{Set|List|Map} #586
Merged
timtebeek
merged 12 commits into
openrewrite:main
from
BramliAK:issue-489-NoGuavaImmutableListOf.stream
Oct 22, 2024
Merged
Fix Guava Immutable{Set|List|Map} #586
timtebeek
merged 12 commits into
openrewrite:main
from
BramliAK:issue-489-NoGuavaImmutableListOf.stream
Oct 22, 2024
+401
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue-520: fix isParentTypeDownCast throws IndexOutOfBoundsException
BramliAK
changed the title
issue-489: fix ImmutableList.of(1, 2).stream()
issue-489/520: fix Guava Immutable{Set|List|Map}
Oct 20, 2024
BramliAK
changed the title
issue-489/520: fix Guava Immutable{Set|List|Map}
Issue-489/520: fix Guava Immutable{Set|List|Map}
Oct 20, 2024
timtebeek
changed the title
Issue-489/520: fix Guava Immutable{Set|List|Map}
Fix Guava Immutable{Set|List|Map}
Oct 22, 2024
Loading status checks…
Loading status checks…
timtebeek
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome to see the detailed work you've done here @BramliAK . Great to convert yet more cases and clear out assigned types as well. Very much appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
issue-489: fix ImmutableList.of(1, 2).stream()
issue-520: fix isParentTypeDownCast throws IndexOutOfBoundsException
convert all immulable {{Set|List|Map} to {Set|List|Map}.of with return type
covert nested class
NoGuavaImmutableListOf
onImmutableList.of(1, 2).stream()
#489Checklist