Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Guava Immutable{Set|List|Map} #586

Merged

Conversation

BramliAK
Copy link
Contributor

@BramliAK BramliAK commented Oct 20, 2024

What's changed?

issue-489: fix ImmutableList.of(1, 2).stream()
issue-520: fix isParentTypeDownCast throws IndexOutOfBoundsException
convert all immulable {{Set|List|Map} to {Set|List|Map}.of with return type
covert nested class

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Sorry, something went wrong.

issue-520: fix isParentTypeDownCast throws IndexOutOfBoundsException
github-actions[bot]

This comment was marked as outdated.

@BramliAK BramliAK changed the title issue-489: fix ImmutableList.of(1, 2).stream() issue-489/520: fix Guava Immutable{Set|List|Map} Oct 20, 2024
@BramliAK BramliAK changed the title issue-489/520: fix Guava Immutable{Set|List|Map} Issue-489/520: fix Guava Immutable{Set|List|Map} Oct 20, 2024
@knutwannheden
Copy link
Contributor

@BramliAK Coincidentally I just merged #583 which modifies the same file, which requires a rebase here. I wasn't aware of your PR at the time. Hope conflict resolution isn't too difficult!

github-actions[bot]

This comment was marked as outdated.

@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Oct 21, 2024
@timtebeek timtebeek changed the title Issue-489/520: fix Guava Immutable{Set|List|Map} Fix Guava Immutable{Set|List|Map} Oct 22, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome to see the detailed work you've done here @BramliAK . Great to convert yet more cases and clear out assigned types as well. Very much appreciated!

@timtebeek timtebeek merged commit 4d09463 into openrewrite:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
3 participants