Add lombok-mapstruct-binding during Java 17 migration when both lombok and mapstruct are used
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen both mapstruct and lombok are used
3 tasks
timtebeek
reviewed
Nov 21, 2024
timtebeek
approved these changes
Nov 21, 2024
Laurens-W
force-pushed
the
lombom-mapstruct-java-17-migration
branch
from
318b44a to
76d0609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added declarative recipe that adds
lombok-mapstruct-bindingwhen both MapStruct and Lombok are usedWhat's your motivation?
This Annotation processor is required from Java 17 for the combination to work
Anyone you would like to review specifically?
@timtebeek @sambsnyd
Checklist