Recipe to convert explicit getters to the Lombok annotation

[timo-a]

What's changed?

Adds new recipe to convert explicit getter methods to the lombok annotation

What's your motivation?

• Fix Auto Lombok @Getter rewrite#3157

Anything in particular you'd like reviewers to focus on?

Please check especially the naming.

Anyone you would like to review specifically?

@timtebeek as discussed this is the first of several of my lombok recipes to be moved to rewrite-migrate-java

Have you considered any alternatives or workarounds?

Any additional context

This recipe was written before the introduction of traits. I guess the methods of the utils class could be traits nowadays but I'd need really specific hints to use traits here.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Great to see this already @timo-a ! I've added some polish to move the field/method name check to utils as well, and added a failing test for the inner class case not yet covered. Figured you might like the puzzle of solving that one, but do let me know if you'd like some more guidance, or me stepping in for the fix there.

[timo-a]

Could you step in, please @timtebeek ? I don't have a lot of time at the moment.

BTW, you included a name check in isEffectivelyGetter. But that method didn't check the name because later recipes needed it not to (that's what I meant with "effectively": It acts as a getter, even if the name doesn't match). I have therefore renamed the method to isGetter and will reintroduce the original isEffectivelyGetter with a future recipe.

[timtebeek]

Thanks a lot for the work done here @timo-a ! The tests made it easy to simplify the logic. I quite like what we've arrived at now: just a single pass through method declarations, with doAfterVisit to annotate the field based on type, not simple name.

[timo-a]

Thanks, I had no idea you could stack doAfterVisit calls, this looks much cleaner now!