Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip code references in comment #638

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: Skip code references in comment #638

merged 3 commits into from
Dec 19, 2024

Conversation

amishra-u
Copy link
Contributor

@amishra-u amishra-u commented Dec 19, 2024 •
edited by timtebeek
Loading

What's changed?

Recipe doesn't have any handling for migrating code references in comments, so skip those.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

timtebeek
timtebeek approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for yet another quick fix.

@timtebeek timtebeek merged commit 1bcf355 into openrewrite:main Dec 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@amishra-u amishra-u

Labels
None yet
Projects
OpenRewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Joda Recipe ClassCastException Javadoc$Reference
2 participants
@amishra-u @timtebeek