Correctly link refaster recipes (#92)

openrewrite · Dec 14, 2023 · aa04d1a · aa04d1a
1 parent dc2ecd2
commit aa04d1a
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 2 deletions.
diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml
@@ -34,7 +34,7 @@ jobs:
       - name: build
         uses: gradle/gradle-build-action@v2
         with:
-          arguments: ${{ env.GRADLE_SWITCHES }} markdownToHtml
+          arguments: ${{ env.GRADLE_SWITCHES }} check markdownToHtml
 
       - name: Create index.html
         run: cp build/html/SUMMARY_snippet.html build/html/index.html

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -54,6 +54,9 @@ dependencies {
     implementation("io.github.java-diff-utils:java-diff-utils:4.11")
     runtimeOnly("org.slf4j:slf4j-simple:1.7.30")
 
+    testImplementation("org.junit.jupiter:junit-jupiter-api:latest.release")
+    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:latest.release")
+
     "recipe"(platform("org.openrewrite:rewrite-bom:$rewriteVersion"))
     "recipe"("org.openrewrite:rewrite-core")
     "recipe"("org.openrewrite:rewrite-groovy")
@@ -111,6 +114,10 @@ tasks.named<JavaCompile>("compileJava") {
     targetCompatibility = JavaVersion.VERSION_17.toString()
 }
 
+tasks.withType<Test> {
+    useJUnitPlatform()
+}
+
 application {
     mainClass.set("org.openrewrite.RecipeMarkdownGenerator")
 }

diff --git a/src/main/kotlin/org/openrewrite/RecipeOrigin.kt b/src/main/kotlin/org/openrewrite/RecipeOrigin.kt
@@ -18,7 +18,7 @@ class RecipeOrigin(
     fun isFromCoreLibrary() = groupId == "org.openrewrite" && coreLibs.contains(artifactId)
 
     private fun convertNameToJavaPath(recipeName: String): String =
-        recipeName.replace('.', '/').removeSuffix("Recipe") + ".java"
+        recipeName.replace('.', '/').replace(Regex("Recipes?\\$?.*"), "") + ".java"
 
     fun githubUrl(recipeName: String, source: URI): String {
         val sourceString = source.toString()

diff --git a/src/test/kotlin/org/openrewrite/RecipeOriginTest.kt b/src/test/kotlin/org/openrewrite/RecipeOriginTest.kt
@@ -0,0 +1,21 @@
+package org.openrewrite
+
+import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.api.Test
+import java.net.URI
+
+class RecipeOriginTest {
+    @Test
+    fun githubUrl() {
+        val githubUrl = RecipeOrigin(
+            "org.openrewrite.recipe", "rewrite-migrate-java", "2.4.2", URI.create("file:///tmp/foo")
+        ).githubUrl(
+            "org.openrewrite.java.migrate.apache.commons.lang.ApacheCommonsStringUtilsRecipes\$AbbreviateRecipe",
+            URI("https://github.com")
+        )
+        assertEquals(
+            "https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/java/org/openrewrite/java/migrate/apache/commons/lang/ApacheCommonsStringUtils.java",
+            githubUrl
+        )
+    }
+}