Fix bug in InstanceOfPatternMatch getting the variable name from the name of a nested class #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e name of a nested class
timtebeek
approved these changes
May 10, 2024
| if (className.indexOf('.') > 0) { | ||
| className = className.substring(className.lastIndexOf('.')); | ||
| } | ||
| className = className.substring(className.lastIndexOf('.') + 1); |
There was a problem hiding this comment.
Subtle using last index of being -1 here and adding 1; unless it's found in which case you skip. Smart. :)
|
Thank you for reviewing and merging the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fix bug in InstanceOfPatternMatch getting the variable name from the name of a nested class.
What's your motivation?
Fixes #290
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Any additional context
Checklist