Visit multiple elements for diverse before templates

[timtebeek]

What's your motivation?

Before this change the order of before templates determined which visit method (singular) to generate, and searched for all before templates from that single visit method. This is not correct, and leads to some before templates not matching when they would require to visit a different element.

Have you considered any alternatives or workarounds?

Not compile refaster templates that would require us to visit different elements.

Any additional context

• Fixes StringIsEmpty with Refaster test fails moderneinc/rewrite-recipe-starter#66

[timtebeek]

Confirmed that this recipe now makes the tests in rewrite-recipe-starter pass

import com.google.errorprone.refaster.annotation.AfterTemplate;
import com.google.errorprone.refaster.annotation.BeforeTemplate;
import org.openrewrite.java.template.RecipeDescriptor;

@RecipeDescriptor(
        name = "Standardize empty String checks",
        description = "Replace calls to `String.length() == 0` with `String.isEmpty()`."
)
public class StringIsEmpty {

    @BeforeTemplate
    boolean lengthIsZero(String s) {
        return s.length() == 0;
    }

    @BeforeTemplate
    boolean zeroIsLength(String s) {
        return 0 == s.length();
    }

    @BeforeTemplate
    boolean equalsEmptyString(String s) {
        return s.equals("");
    }

    @BeforeTemplate
    boolean emptyStringEquals(String s) {
        return "".equals(s);
    }

    @BeforeTemplate
    boolean lessThanOne(String s) {
        return s.length() < 1;
    }

    @BeforeTemplate
    boolean oneGreaterThanLength(String s) {
        return 1 > s.length();
    }

    @AfterTemplate
    boolean isEmpty(String s) {
        return s.isEmpty();
    }
}