Add doAfterVisit(UnnecessaryParentheses)
to generated recipes
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Until we update the JavaTemplate to detect and insert parentheses around for instance binary expressions, we need a quick way to move along openrewrite/rewrite-migrate-java#271 ; With this change we're able to add parentheses to the templates defined there, which are then cleaned up through
UnnecessaryParentheses
.Have you considered any alternatives or workarounds?
We could always add parentheses in the JavaTemplate Strings produced by
TemplateProcessor
here; that might be a bit excessive, but would prevent us from having to add those parentheses to rewrite-migrate-java.Any additional context